-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Migrate from scss-lint to stylelint #443
Comments
@jglovier I'm fine with the change as long as it gets into the testing process with Travis. If we move to this we will also need to remove the ember-cli-scss-lint Ember addon. |
Probably the best way to do this would be to build |
@jkleinsc and I looked into switching to |
so this is ready for use https://www.npmjs.com/package/ember-cli-style-lint |
cc @jonrohan |
This is a pretty new package https://github.com/kristerkari/stylelint-scss/ that has a lot of scss specific rules for stylelint. A++ would recommend |
Closed in #488. |
Scss-lint is giving us huge value in helping keep our CSS structured, consistent, and maintainable. The huge downside for our project, however, is that it requires Ruby, and as a Node based project that makes getting started for new contributors (especially Windows devs who don't have Ruby already installed on their machine) a significant barrier.
Scss-lint does have a Node ported version, but unfortunately it doesn't support all of the linters we need, including a few of the most valuable ones.
However, there is hope. And it's name is Stylelint. Stylelint appears to support everything that Scss-lint does, and has even more features. And best of all it is made for Node projects so it's way faster than Scss-lint (we've done some comparrison tests at GH and we are strongly considering moving from Scss-lint internally to Stylelint), and it would mean we no longer require Ruby for our app.
I'm strongly in favor of moving to Stylelint. Any objections?
cc @HospitalRun/core-maintainers
Notes:
TODO
The text was updated successfully, but these errors were encountered: