Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

Spaces in username, during logging #922

Closed
tleb opened this issue Jan 13, 2017 · 3 comments
Closed

Spaces in username, during logging #922

tleb opened this issue Jan 13, 2017 · 3 comments
Labels
help wanted indicates that an issue is open for contributions

Comments

@tleb
Copy link

tleb commented Jan 13, 2017

Expected behavior:

Space trimming

Actual behavior:

A Username or password is incorrect. error.

Steps to reproduce:

Go on demo, try an ID with a space in front or behind it ; it doesn't work.

Great projet BTW!

@greym0uth
Copy link

A simple fix would be to just trim the spaces, but couldn't it be a breach in security if you allowed the user access if they accidentally entered a space, or any invalid character, anywhere in the credentials?

@tleb
Copy link
Author

tleb commented Jan 19, 2017

I don't see why, you just delete the ones at the beginning and at the end and those in between are part of the username. But, should spaces be allowed at all?

@jkleinsc
Copy link
Member

Usernames shouldn't have spaces in them, and it makes sense to trim any spaces on login. It is a simple change that should produce a better user experience.

@tangollama tangollama added the help wanted indicates that an issue is open for contributions label Mar 14, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
help wanted indicates that an issue is open for contributions
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants