Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove netty package from API module #211

Merged
merged 3 commits into from
Jul 11, 2018
Merged

Remove netty package from API module #211

merged 3 commits into from
Jul 11, 2018

Conversation

kvosper
Copy link
Contributor

@kvosper kvosper commented Jul 10, 2018

Implementation of #207

mikkokar
mikkokar reviewed Jul 11, 2018
View reviewed changes
components/api/src/main/java/com/hotels/styx/api/HttpResponse.java Outdated
static {
LoggerFactory.getLogger(HttpResponse.class).info("Running my latest build!");
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to back this off?

@mikkokar mikkokar merged commit da55fc6 into ExpediaGroup:styx-1.0-dev Jul 11, 2018
@kvosper kvosper deleted the remove-netty-package-from-api branch July 11, 2018 13:45
@mikkokar mikkokar changed the title Move classes out of package Remove netty package from API module Jul 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikkokar mikkokar mikkokar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kvosper @mikkokar