Migrate ConnectionPool related API classes to Styx Client module #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvosper
suggested changes
Aug 3, 2018
| @@ -365,17 +364,6 @@ public Builder connectionPoolConfig(ConnectionPoolSettings connectionPoolSetting | |||
| return this; | |||
| } | |||
|
|
|||
| /** | |||
There was a problem hiding this comment.
The field connectionPoolSettings can no longer be set at all.
kvosper
approved these changes
Aug 3, 2018
mikkokar
force-pushed
the
api-tidy-up
branch
2 times, most recently
from
e745f28
to
32070e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To reduce classes in the public API module, and to reduce its dependencies to
rx.Specifically:
ConnectionPool.Settingsinterface. Instead, we now have a data class calledConnectionPoolSettings. Similar refactoring has been done toConnection.Settingsinterface.