Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #234 remove application configuration matcher #237

Conversation

VivianLopes
Copy link
Contributor

Removed unused ApplicationConfigurationMatcher.

@dvlato
Copy link
Contributor

dvlato commented Aug 21, 2018

Would you like to reference the issue using the "#" notation? That is, don't write issue '234' but #234
You can also autoclose issues as per this notation (you can do it in the pull request body rather than the commit message): https://help.github.com/articles/closing-issues-using-keywords/

Copy link
Contributor

@kvosper kvosper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this was branched from VivianLopes:issue_183_remove_admin_endpoints instead of HotelsDotCom:styx-1.0-dev, as it has changes from that other branch in this PR.

@VivianLopes VivianLopes force-pushed the issue_234_remove_ApplicationConfigurationMatcher branch from 4a36a2d to 3206c59 Compare August 21, 2018 12:31
@dvlato dvlato changed the title Issue 234 remove application configuration matcher Issue #234 remove application configuration matcher Aug 21, 2018
@dvlato dvlato changed the title Issue #234 remove application configuration matcher Fixes #234 remove application configuration matcher Aug 21, 2018
@mikkokar mikkokar merged commit e8d0988 into ExpediaGroup:styx-1.0-dev Aug 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants