Issue #264: Remove unnecessary calls to freePort.
#265
Conversation
have an unused port, because we want to keep the origin unreachable.
| .start(); | ||
|
|
||
| FullHttpResponse response = doGet("/"); | ||
|
|
||
| assertThat(response.status(), is(OK)); | ||
| assertThat(response.status().code(), is(OK.code())); |
There was a problem hiding this comment.
Why was this necessary? If they don't match, it may indicate that the classes are not the same, e.g. Styx HttpResponseStatus vs Netty HttpResponseStatus.
There was a problem hiding this comment.
Ok. Importing now Styx HttpResponseStatus instead of Netty.
| HttpServer server = NettyServerBuilder.newBuilder() | ||
| .setHttpConnector(connector(port)) | ||
| .setHttpConnector(connector(0)) |
There was a problem hiding this comment.
I would say the code is a bit easier to write if we use freeport for the cases with '0' and WireMockServer.dynamic*Port() instead of having to find what's the correct way to get a random port in each case. That doesn't mean we have to keep the 'port' variable used later...
There was a problem hiding this comment.
Hi @dvlato. freePort is problematic because it can easily cause port conflicts in parallel environments. Because it is susceptible for race conditions it should be avoided.
Fixes #264.