Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve origins health check metric name #269

Closed
mikkokar opened this issue Sep 5, 2018 · 0 comments
Closed

Improve origins health check metric name #269

mikkokar opened this issue Sep 5, 2018 · 0 comments
Assignees
@kvosper
Labels
enhancement

Comments

@mikkokar
Copy link
Contributor

mikkokar commented Sep 5, 2018

The problem

The origins health check failure metric name name doesn't fit in the existing naming hierarchy. The metrics name, like the other origin specific metrics, should be:

origins.<BACKEND-ID>.healthcheck.failure

Acceptance criteria

  • Deprecate the old metric name.
  • Add new origins.<backend-id>.healthcheck.failure metric alongside the old metric.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kvosper kvosper

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mikkokar @kvosper