Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tidy up styx-api module for 1.0 release #272

Merged
merged 3 commits into from
Sep 7, 2018
Merged

Tidy up styx-api module for 1.0 release #272

merged 3 commits into from
Sep 7, 2018

Conversation

mikkokar
Copy link
Contributor

@mikkokar mikkokar commented Sep 6, 2018

Small code janitoring for the API module:

  • Move NoServiceConfiguredException from styx-api to styx-server module.
  • Reduce class visibility of FullHttpMessage and StreamingHttpMessage: package private
  • Move CustomHttpResponseStatus codes to styx-proxy module.

@mikkokar mikkokar merged commit 4a10ffd into ExpediaGroup:master Sep 7, 2018
@mikkokar mikkokar deleted the styx-1.0-api-tidyup branch September 7, 2018 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kvosper kvosper kvosper approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikkokar @kvosper