Move isSecure flag to HttpInterceptor.Context #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Concludes the work for #274.
isSecureattribute from HTTP request objects intoHttpInterceptor.Context.This has an implication to a request logging feature. The isSecure is no longer a request attribute, and therefore it no longer appears in request's textual representation. It is logged separately from the request, but only when Interceptor.Context is available. Therefore
isSecureis logged for the inbound requests because the interceptor context is visible for the inbound request logger. But it is not logged for outbound requests because the context is not visible to the StyxHttpClient that logs the outbound requests.