Update ContentCutoffPlugin and enable test in DoubleSubscriptionPluginSpec #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikkokar
suggested changes
Sep 13, 2018
|
|
||
| // TODO: Mikko: Styx 2.0 API: Test fails. Look into it. | ||
| ignore("Tolerates plugins that break the content observable chain") { | ||
| it("Tolerates plugins that break the content observable chain") { | ||
| val testClient = aggregatingTestClient("localhost", styxServer.httpPort) | ||
|
|
||
| withTestClient(testClient) { |
There was a problem hiding this comment.
I think this test should assert that a PluginError has been logged. It could also assert that relevant metrics have been incremented.
Otherwise this test suggests there is nothing unusual about breaking a content observable chain.
| .flatMap(it -> { | ||
| LOGGER.info("do something with full content: " + it.bodyAs(UTF_8)); | ||
|
|
||
| return StyxObservable.of(response); // Error: Returns an already consumed response. |
There was a problem hiding this comment.
I would move the comment to the line above the return statement.
mikkokar
approved these changes
Sep 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #203