Update example plugin to latest api #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikkokar
approved these changes
Oct 22, 2018
dvlato
reviewed
Oct 22, 2018
| .build(); | ||
|
|
||
|
|
||
| //The method StyxFutures.await() in styx-common wraps future.get() including appropriate Exception handling. |
There was a problem hiding this comment.
StyxFutures is not included in the API, so we should probably remove this comment.
Additionally, we have two utility classes for CompetableFutures in the same module+package, StyxFutures and CompletableFutures. Maybe we want to take this chance to fix that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.