Update plugins-scenarios.md to Styx 1.0 API #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvlato
approved these changes
Oct 24, 2018
kvosper
suggested changes
Oct 24, 2018
kvosper
suggested changes
Oct 25, 2018
| - Continuity (or discontinuity) of Styx content observable. Each content tranformation with | ||
| `map` or `flatMap` is a composition of some source observable. So is each content transformation | ||
| linked to some source observable, an ultimate source being the Styx server core. | ||
| - **Reference counting.** Styx exposes the content stream as a `ByteStream` of reference counted |
There was a problem hiding this comment.
Reference counting. Styx exposes the cont
->
Reference counting: Styx exposes the cont
| Remember that `chain.proceed` returns an `Observable<HttpResponse>` it is therefore | ||
| interface compatible and can be `flatMap`'d to the response observable. The resulting | ||
| response observable chain is returned from the `intercept`. | ||
| Step 5. Finally, we will bind the outcome from `chain.proceed` into the response eventual. |
There was a problem hiding this comment.
I would suggest always using "Eventual" to refer to the class, rather than "eventual", as this is a particular concept for Styx, rather than the normal use of the word (which is just an adjective).
kvosper
suggested changes
Oct 25, 2018
Co-Authored-By: mikkokar <mikko.e.karjalainen@gmail.com>
Co-Authored-By: mikkokar <mikko.e.karjalainen@gmail.com>
Co-Authored-By: mikkokar <mikko.e.karjalainen@gmail.com>
Co-Authored-By: mikkokar <mikko.e.karjalainen@gmail.com>
Co-Authored-By: mikkokar <mikko.e.karjalainen@gmail.com>
Co-Authored-By: mikkokar <mikko.e.karjalainen@gmail.com>
Co-Authored-By: mikkokar <mikko.e.karjalainen@gmail.com>
kvosper
suggested changes
Oct 29, 2018
Co-Authored-By: mikkokar <mikko.e.karjalainen@gmail.com>
Co-Authored-By: mikkokar <mikko.e.karjalainen@gmail.com>
Co-Authored-By: mikkokar <mikko.e.karjalainen@gmail.com>
kvosper
approved these changes
Oct 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
plugins-scenarios.mdto Styx 1.0.