Remove singleton dependency from request tracker unit tests. #340
Conversation
Also tidy up the code a bit.
components/proxy/src/main/java/com/hotels/styx/admin/handlers/CurrentRequestsHandler.java
Outdated
Show resolved
Hide resolved
components/server/src/main/java/com/hotels/styx/server/track/CurrentRequestTracker.java
Outdated
Show resolved
Hide resolved
| public static final CurrentRequestTracker INSTANCE = new CurrentRequestTracker(); | ||
|
|
||
| private CurrentRequestTracker() { |
There was a problem hiding this comment.
Instead of letting the CurrentRequestTracker be the default, I would rather set the appropriate visibility (hopefully package private will suffice) and annotate the method with @VisibleForTesting. Probably we should redesign something if need public visibility as this is supposed to be a singleton...
There was a problem hiding this comment.
Not sure what you mean @dvlato? If you refer to constructor visibility, package private is not enough because we need to create instances in various test cases outside of track package.
There was a problem hiding this comment.
That's quite unfortunate. I would still at least create a explicit constructor with the @VisibleForTesting annotation. Another option would be to have a private constructor and a static factory method that has the visible for testing annotation.
Also tidy up the code a bit.