Use Long to represent Content-Length #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvlato
reviewed
Dec 7, 2018
components/api/src/main/java/com/hotels/styx/api/HttpResponse.java
Outdated
Show resolved
Hide resolved
kvosper
suggested changes
Dec 11, 2018
| @@ -728,10 +728,10 @@ private void ensureContentLengthIsValid() { | |||
| return headerValues.isEmpty() ? Optional.empty() : Optional.of(headerValues.get(0)); | |||
| } | |||
|
|
|||
| private static boolean isInteger(String contentLength) { | |||
| private static boolean isPositiveInteger(String contentLength) { | |||
There was a problem hiding this comment.
Suggested change
| private static boolean isPositiveInteger(String contentLength) { | |
| private static boolean isNonNegativeInteger(String contentLength) { |
Generally the term "positive integer" refers to an integer greater than zero. I'm not sure if there is an official ruling for numbers in Java, but this is the use of the term I am familiar with.
components/api/src/main/java/com/hotels/styx/api/LiveHttpRequest.java
Outdated
Show resolved
Hide resolved
kvosper
approved these changes
Dec 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.