Improve log message on plugin load fail/Decouple failure handling from task execution #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvlato
suggested changes
Jan 17, 2019
components/common/src/main/java/com/hotels/styx/common/FailureHandlingTaskProcessor.java
Outdated
Show resolved
Hide resolved
components/common/src/main/java/com/hotels/styx/common/FailureHandlingTaskProcessor.java
Outdated
Show resolved
Hide resolved
components/common/src/main/java/com/hotels/styx/common/FailureHandlingTaskProcessor.java
Outdated
Show resolved
Hide resolved
components/common/src/main/java/com/hotels/styx/common/FailureHandlingTaskProcessor.java
Outdated
Show resolved
Hide resolved
components/proxy/src/main/java/com/hotels/styx/proxy/plugin/PluginSuppliers.java
Outdated
Show resolved
Hide resolved
dvlato
approved these changes
Jan 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a common class called
FailureHandlingStrategythat can be used to decouple failure-handling logic from the logic of processing items in a list.Demonstrating this decoupling are the changes in
PluginSuppliers, which also fixes #372.