-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor plugin loading #378
Refactor plugin loading #378
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additionally to my comments, I believe the description of the PR doesn't make it clear what the relevant changes are or why it is needed. Since it's quite a big PR I guess it would make sense to provide some guidance to people checking differences between versions and similar. (as well as for people reviewing the code!)
The primary focus of this PR is to decouple the Admin server from the plugin-loading, so that will be able to visit the admin server before the plugins have all been loaded.
That work is not totally finished by this PR (as it is already quite large and we don't want to add even more changes).
I have also taken the opportunity to tidy-up parts of the plugin-loading code that were messy.
It is a prerequisite to allowing Styx to have proper liveness/readiness checks, which needs the admin server to be able to start without waiting for the plugins.