Improve Styx Dockerfile #381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) development images and 2) official Styx release images. Remove the release version number from Styx assembly base directory name. The version number is still present in the release zip file name.
dvlato
approved these changes
Mar 7, 2019
docker/README.md
Outdated
| @@ -31,7 +31,8 @@ Ensure the the Styx configuration reads the origins from `/styx/config/` directo | |||
|
|
|||
| Finally, start the Styx Docker image using `/styx/config/styxconf.yml` as a configuration file: | |||
|
|
|||
| docker container run -d --name myStyx \ | |||
| -p 8080:8080 -p 9000:9000 -p 8443:8443 | |||
| docker container run -d \ | |||
There was a problem hiding this comment.
maybe keep the name as in the previous examples and suggest --rm ?
There was a problem hiding this comment.
Changed the code as you suggested. Please have a look again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generify Dockerfile so that it can be used for building both development images and official Styx release images.
This change also removes the release version number from Styx assembly base directory.
That is the top-level directory in a Styx release zip file. The version number in the base directory is pointless because it is in the release zip file anyway, and it unnecessarily complicates the Dockerfile and possibly other release scripts.