Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move version files property into user defined #411

Merged
merged 3 commits into from
May 16, 2019
Merged

Move version files property into user defined #411

merged 3 commits into from
May 16, 2019

Conversation

kvosper
Copy link
Contributor

@kvosper kvosper commented May 15, 2019

Implements #410

@kvosper kvosper requested review from mikkokar and dvlato May 15, 2019 15:50
import com.hotels.styx.infrastructure.HttpResponseImplicits
import org.scalatest.{FunSpec, Matchers}

class VersionFilesPropertySpec extends FunSpec with StyxProxySpec with Matchers with HttpResponseImplicits {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take this opportunity to move this test to Kotlin system test suite.

@mikkokar mikkokar merged commit b846875 into ExpediaGroup:master May 16, 2019
@kvosper kvosper deleted the move-version-files-property-into-user-defined branch May 23, 2019 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants