Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Host proxy object #423

Merged
merged 2 commits into from
Jun 11, 2019
Merged

Host proxy object #423

merged 2 commits into from
Jun 11, 2019

Conversation

mikkokar
Copy link
Contributor

@mikkokar mikkokar commented Jun 4, 2019

Adds a new routing object: HostProxy. It proxies traffic to single configured endpoint.

It supports:

  • Styx connection pool (with expiring connections)
  • TLS settings
  • Response timeout configuration
  • Origin/Application and connection pool metrics.
  • A metric prefix for backwards compatibility

The following "features" are omitted from this pull request:

  • Request logging at styx client level. This shouldn't be necessary as logging could be implemented as a separate routing object.
  • Origin/Application metrics are not de-registered after the host proxy object is removed. Styx application routing at present doesn't de-register them anyway, and therefore we'd have to implement this as a separate increment.

@mikkokar mikkokar merged commit 5bd80f7 into ExpediaGroup:master Jun 11, 2019
@mikkokar mikkokar deleted the host-proxy-object branch June 11, 2019 13:20
dvlato pushed a commit that referenced this pull request Jul 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants