Update config documentation #426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvlato
reviewed
Jun 10, 2019
dvlato
reviewed
Jun 10, 2019
Co-Authored-By: David Latorre <dvlato@gmail.com>
Co-Authored-By: David Latorre <dvlato@gmail.com>
… into update-config-documentation
dvlato
reviewed
Jun 10, 2019
dvlato
reviewed
Jun 10, 2019
dvlato
reviewed
Jun 11, 2019
| # If set to 0, availableProcessors / 2 threads will be used | ||
| clientWorkerThreadsCount: 0 | ||
| # Worker threads are those performing all the asynchronous I/O operation on the inbound channel. | ||
| # If set to 0, availableProcessors / 2 threads will be used |
There was a problem hiding this comment.
I think I would still remove this "If set to 0", as IIRC this was not the case here. Then let's change the example to something different from 0!
dvlato
approved these changes
Jun 11, 2019
mikkokar
reviewed
Jun 11, 2019
| public int maxContentLength() { | ||
| return this.maxContentLength; | ||
| } | ||
|
|
||
| /** | ||
| * Time in milliseconds Styx Proxy Service waits for an incoming request from client. |
There was a problem hiding this comment.
This description is bit vague.
It would be worth clarifying that this parameter controls the amount of tolerated inactivity while the request is being received. If the client started sending the request, and then suddenly cuts it off, styx would detect this after requestTimeoutMillis.
mikkokar
approved these changes
Jun 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.