Add plugin examples to Styx #432
Conversation
kvosper
requested review from
mikkokar and
dvlato
and removed request for
mikkokar
plugin-examples/pom.xml
Outdated
| @@ -1,205 +1,82 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
| <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | |||
| xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd"> | |||
| <parent> | |||
There was a problem hiding this comment.
If we add the parent as a dependency, all the parent pom's dependencies will be transitive dependencies of the plugin. This means that if we wanted to shade it with all its dependencies in a later stage we would re-add (with a different package name) many of Styx dependencies we don't really need...
There was a problem hiding this comment.
I would probably recommend using composition (i.e., importing a pom) here. In any case, it would be great if you could verify that if we try to use the add the plugin to Styx it's easy to include the required dependencies only.
There was a problem hiding this comment.
This change was added to ensure that the plugin examples build properly as part of the Styx project. I will see if any alternative is possible.
plugin-examples/pom.xml
Outdated
| </dependency> | ||
| <dependency> | ||
| <groupId>io.reactivex</groupId> | ||
| <artifactId>rxjava</artifactId> | ||
| <version>${rxjava.version}</version> | ||
| <scope>provided</scope> |
There was a problem hiding this comment.
I would keep the provided scope as this is still not needed in our "plugin bundle"
plugin-examples/pom.xml
Outdated
| <dependencies> | ||
| <dependency> | ||
| <groupId>com.hotels.styx</groupId> | ||
| <artifactId>styx-api</artifactId> | ||
| <version>${styx.version}</version> | ||
| <!-- The dependency is explicitlu needed only during compile time, styx is already available in the runtime--> | ||
| <scope>provided</scope> |
There was a problem hiding this comment.
I would still keep the provided scope as we don't need to package/bundle the api with our plugin.
This PR adds some plugin example classes.