Config validation on programmatic start #435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvosper
requested review from
dvlato and
mikkokar
and removed request for
dvlato
mikkokar
suggested changes
Jun 24, 2019
components/proxy/src/main/kotlin/com/hotels/styx/StyxConfigValidation.kt
Outdated
Show resolved
Hide resolved
components/proxy/src/main/kotlin/com/hotels/styx/StyxConfigValidation.kt
Outdated
Show resolved
Hide resolved
mikkokar
approved these changes
Jun 25, 2019
components/proxy/src/test/java/com/hotels/styx/StyxConfigValidationKtTest.java
Outdated
Show resolved
Hide resolved
components/common/src/main/java/com/hotels/styx/common/testing/ExceptionExpectation.java
Outdated
Show resolved
Hide resolved
mikkokar
suggested changes
Jun 25, 2019
There was a problem hiding this comment.
Let's avoid adding new classes unless absolutely necessary.
Kotlin tests already provide exception matchers out of box. No need to implement them.
The laziness seems a premature optimisation which also adds bloat to the code. I would encourage removing that. Unless I am missing something?
dvlato
suggested changes
Jun 26, 2019
components/proxy/src/main/kotlin/com/hotels/styx/StyxConfigValidation.kt
Outdated
Show resolved
Hide resolved
dvlato
suggested changes
Jun 28, 2019
dvlato
approved these changes
Jun 28, 2019
mikkokar
approved these changes
Jul 1, 2019
components/proxy/src/main/java/com/hotels/styx/startup/StyxServerComponents.java
Outdated
Show resolved
Hide resolved
dvlato
pushed a commit
that referenced
this pull request
Jul 3, 2019
Validate config when StyxServer is started programmatically
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have config validation take place when StyxServer is created programmatically, e.g. for tests.