Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preregister styx errors metric #445

Merged
merged 2 commits into from
Jul 10, 2019
Merged

Preregister styx errors metric #445

merged 2 commits into from
Jul 10, 2019

Conversation

kvosper
Copy link
Contributor

@kvosper kvosper commented Jul 9, 2019

This means we can find the expected metric names in the registry (and an initial value of zero), even before the corresponding events have occurred.

@kvosper kvosper requested review from mikkokar and dvlato July 9, 2019 15:08
@mikkokar mikkokar merged commit e8cab2e into ExpediaGroup:master Jul 10, 2019
@kvosper kvosper deleted the preregister-styx-errors-metric branch July 10, 2019 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dvlato dvlato dvlato approved these changes

@mikkokar mikkokar mikkokar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kvosper @mikkokar @dvlato