Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Config validation expects "styxInfo:format" instead of "styxInfo:valueFormat" #459

Merged
merged 1 commit into from
Sep 19, 2019
Merged

Config validation expects "styxInfo:format" instead of "styxInfo:valueFormat" #459

merged 1 commit into from
Sep 19, 2019

Conversation

dvlato
Copy link
Contributor

@dvlato dvlato commented Sep 18, 2019 •
edited
Loading

The StyxInfo header has a field called valueFormat but our config validation expected format instead.

@dvlato dvlato changed the title Config validation: "valueFormat" field was called "format" Config validation expects styxInfo:format instead of styxInfo:valueFormat Sep 18, 2019
@dvlato dvlato changed the title Config validation expects styxInfo:format instead of styxInfo:valueFormat Config validation expects "styxInfo:format" instead of "styxInfo:valueFormat" Sep 18, 2019
@mikkokar mikkokar merged commit e0dbda8 into ExpediaGroup:master Sep 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OwenLindsell OwenLindsell OwenLindsell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dvlato @OwenLindsell @mikkokar @a-dlatorre