Make admin interfaces streamable #474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikkokar
suggested changes
Oct 9, 2019
| /** | ||
| * Simple Http Router. | ||
| */ | ||
| public class AdminHttpRouter implements HttpHandler { |
There was a problem hiding this comment.
Hi @taer Thank you for doing this! Very useful. But one comment.
Please move this class to styx-proxy module. This class is called AdminHttpRouter, and you are adding it to the styx-server module which doesn't have an admin interface. The admin interface is in the styx-proxy. Therefore it should live in the proxy module. But otherwise it good to go :-D.
There was a problem hiding this comment.
done. I think the test failure is a timeout based test
- Converted to Kotlin since I saw this was an option now here.
mikkokar
approved these changes
Oct 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should allow plugins to stream requests larger than 1M