Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always enable a check for empty HTTP content. #488

Merged
merged 1 commit into from
Oct 17, 2019

Conversation

mikkokar
Copy link
Contributor

Fixes a possibly hanging bodiless responses from new LoadBalancingGroup object.

Always set Content-Length to zero for bodiless responses (such as 204). The old application router code does this already, but the new load balancing group doesn't. Therefore, Netty appears to add transfer-encoding: chunked but no content ever follows, resulting hung responses.

@dvlato dvlato merged commit 8faac47 into ExpediaGroup:master Oct 17, 2019
@mikkokar mikkokar deleted the check-for-empty-content branch October 17, 2019 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants