Improve make docker-image #493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvlato
reviewed
Oct 23, 2019
Makefile
Outdated
| @@ -29,7 +30,7 @@ e2e: | |||
| # Note: Pre-integration test phase is necessary to produce styx.properties file | |||
| # needed by AdminSpec.scala tests. | |||
| e2e-compile: | |||
| mvn clean pre-integration-test -P$(PLATFORM) | |||
| mvn clean pre-in tegration-test -P$(PLATFORM) | |||
| @@ -155,12 +154,9 @@ changelog: | |||
| # Assuming that styxconf.yml exists in "./docker-config/" directory. | |||
| # Default configuration file: /styx/default-config/default.yml | |||
| # | |||
| distribution/target/styx-1.0-SNAPSHOT-linux-x86_64.zip: | |||
| docker-image: clean | |||
There was a problem hiding this comment.
I seems acceptable that we always have to clean and build to compile the docker image... But we could at least document how to build the docker-image without using the Makefile.
There was a problem hiding this comment.
IMO the makefile itself can work as a documentation.
dvlato
approved these changes
Oct 23, 2019
dvlato
approved these changes
Oct 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures that
make docker-image:I have tested this on Mac OSX and CentOS Docker image.