Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Origins dashboard, initial design #503

Merged
merged 6 commits into from
Nov 14, 2019
Merged

Origins dashboard, initial design #503

merged 6 commits into from
Nov 14, 2019

Conversation

mikkokar
Copy link
Contributor

@mikkokar mikkokar commented Oct 24, 2019 •
edited
Loading

Description

Implement a dashboard that shows, for each application:

  • The path prefix mapping, and the application name
  • Information for each origin:
    • Availability (active/inactive)
    • TLS encrypted or not (http/https)
    • Origin name and hostname
    • The remaining tags, excluding the app membership, and status tags. The app membership and the status can be inferred without showing tags.

This PR also:

  • Adds a kotlin.html dependency
  • Bundles materialize css library in styx (Licensed under MIT license).
  • ClassPathResourceHandler: configurable asset path and request prefix.
  • Modify admin endpoint handlers for YamlFileConfigurationService:
    • assets/. - for serving static assets
    • configuration/ - for origins file
    • origins/ - this new dashboard

Example page

screenshot

@mikkokar mikkokar mentioned this pull request Nov 5, 2019
Closed
@mikkokar
Add basic origins status page for backwards compatibility mode - work…
0418c36 
… in progress
@mikkokar
Temp save:
aa78573 
- Refactored dashboard producer code
- Moved TextHandler to http.handler.HttpContentHandler
@mikkokar mikkokar mentioned this pull request Nov 11, 2019
Closed
@mikkokar
First serious cut for OriginsPageRenderer.
17f030e 
Update ClassPathResourceHandler:
- Configure assets path and request prefix.

Add static assets for Materialize.

Admin endpoints for YamlFileConfigurationService:
- assets/ - for static assets
- configuration/ - for origins file
- origins/ - for origins dashboard

AdminServerBuilder:
- Pass the endpoint prefix as an argument for service provider endpoints
@mikkokar
Display origin host name and port number.
b0c77f4
@mikkokar mikkokar marked this pull request as ready for review November 12, 2019 09:10
chrisgresty
chrisgresty reviewed Nov 14, 2019
View reviewed changes
Copy link
Contributor

@chrisgresty chrisgresty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few naming things, mainly.

components/api/src/main/java/com/hotels/styx/api/extension/service/spi/StyxService.java Outdated Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
components/api/src/main/java/com/hotels/styx/api/extension/service/spi/StyxService.java Outdated Show resolved Hide resolved
components/proxy/pom.xml Outdated Show resolved Hide resolved
components/proxy/src/main/kotlin/com/hotels/styx/ObjectTags.kt Outdated Show resolved Hide resolved
components/server/src/main/java/com/hotels/styx/server/handlers/ClassPathResourceHandler.java Outdated Show resolved Hide resolved
@mikkokar mikkokar merged commit 16c5d9e into ExpediaGroup:master Nov 14, 2019
@mikkokar mikkokar deleted the origins-dashboard branch November 14, 2019 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisgresty chrisgresty chrisgresty left review comments

@OwenLindsell OwenLindsell OwenLindsell approved these changes

@dvlato dvlato Awaiting requested review from dvlato

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mikkokar @OwenLindsell @chrisgresty