Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #498: Provide httpResponse to the whenCompleted event #507

Merged
merged 1 commit into from
Oct 30, 2019
Merged

Issue #498: Provide httpResponse to the whenCompleted event #507

merged 1 commit into from
Oct 30, 2019

Conversation

taer
Copy link
Contributor

@taer taer commented Oct 28, 2019

No description provided.

@taer taer force-pushed the completeGetResponse branch from 4f82d4a to 7ff1f6a Compare October 28, 2019 19:28
mikkokar
mikkokar approved these changes Oct 30, 2019
View reviewed changes
Copy link
Contributor

@mikkokar mikkokar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a useful PR, but it is concerning that nothing prevents API users from attempting to consume the body content from within whenCompleted callback.

Also we should move this to the API module.

But let's do these improvements separately.

@mikkokar mikkokar changed the title Provide httpResponse to the whenCompleted event Issue #498: Provide httpResponse to the whenCompleted event Oct 30, 2019
@mikkokar
Copy link
Contributor

FYI: This fixes: #498.

@mikkokar mikkokar merged commit c4a2cde into ExpediaGroup:master Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikkokar mikkokar mikkokar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@taer @mikkokar