Add a "lbGroup" prefix to load balancing group membership tag. #522
Conversation
Add ObjectTags.kt to serve as a formal specification for tag names.
mikkokar
requested review from
OwenLindsell and
chrisgresty
and removed request for
OwenLindsell
| - state:inactive | ||
| config: | ||
| host: localhost:${appA01.port()} | ||
|
|
||
| app-A-02: | ||
| type: HostProxy | ||
| tags: | ||
| - App-A | ||
| - lbGroup=App-A | ||
| - state:inactive:3 |
There was a problem hiding this comment.
shouldn't this use : instead of = to be consistent with the state:inactive tag?
There was a problem hiding this comment.
Or are we going to standardize on =?
There was a problem hiding this comment.
Hi. I thought about this and chose ’=‘ because ‘:’ already appears in creation time tag values.
Therefore would be best to standardise on ‘=‘. My gut feeling is that it will be less likely to occur in the value parts.
| */ | ||
| package com.hotels.styx | ||
|
|
||
| fun lbGroupTag(name: String) = "lbGroup=$name" |
There was a problem hiding this comment.
I guess you don't need it now (YAGNI, etc.) but do you also see adding functions here to extract the RHS from a tag ? e.g. fun lbGroupTag(tags: Set<String>) : String?
There was a problem hiding this comment.
Hi. Yes. Right now it is unnecessary. But will add if or when necessary.
| - state:inactive | ||
| config: | ||
| host: localhost:${appA01.port()} | ||
|
|
||
| app-A-02: | ||
| type: HostProxy | ||
| tags: | ||
| - App-A | ||
| - lbGroup=App-A | ||
| - state:inactive:3 |
There was a problem hiding this comment.
Or are we going to standardize on =?
Add
lbGroupprefix to load balancing group membership tags. This makes them self-identifying. As a result the tag can be recognised without having to know the load balancing group configuration.Also add a
ObjectTags.ktto serve as a formal specification for tag names.