Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace rxjava for response body content #552

Merged
merged 6 commits into from
Dec 10, 2019
Merged

replace rxjava for response body content #552

merged 6 commits into from
Dec 10, 2019

Conversation

OwenLindsell
Copy link
Contributor

No description provided.

@OwenLindsell OwenLindsell marked this pull request as ready for review December 5, 2019 11:50
chrisgresty
chrisgresty reviewed Dec 9, 2019
View reviewed changes
Copy link
Contributor

@chrisgresty chrisgresty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the one minor comment. Not sure I understand all of this PR - would be interested in going through it with you tomorrow.

...src/main/java/com/hotels/styx/client/netty/connectionpool/NettyToStyxResponsePropagator.java Outdated Show resolved Hide resolved
@OwenLindsell OwenLindsell merged commit 264193d into ExpediaGroup:master Dec 10, 2019
@OwenLindsell OwenLindsell mentioned this pull request Mar 27, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisgresty chrisgresty chrisgresty left review comments

@mikkokar mikkokar mikkokar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@OwenLindsell @mikkokar @chrisgresty