Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an event for headers complete #557

Merged
merged 2 commits into from
Dec 13, 2019
Merged

Add an event for headers complete #557

merged 2 commits into from
Dec 13, 2019

Conversation

taer
Copy link
Contributor

@taer taer commented Dec 6, 2019

Signed-off-by: Robert Macaulay rmacaulay@homeaway.com

@taer taer marked this pull request as ready for review December 6, 2019 21:49
@taer
Copy link
Contributor Author

taer commented Dec 6, 2019

Test failure seems to be a timeout one.

mikkokar
mikkokar approved these changes Dec 10, 2019
View reviewed changes
Copy link
Contributor

@mikkokar mikkokar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @taer looks good, but could you also contribute a test for the completeness? ;-)

Will approve and merge anyway.

@mikkokar
Copy link
Contributor

@taer can you try to trigger another test run to get the build green?
Rebasing to latest master might help.

@taer
Copy link
Contributor Author

taer commented Dec 12, 2019 

[ERROR]   HostProxySpec Test failed after 1 seconds; attempted 52 times; underlying cause was expected: 1 but was: 0

I'll rebase

Robert Macaulay added 2 commits December 12, 2019 15:37
Add an event for headers complete
ce6e511 
Signed-off-by: Robert Macaulay <rmacaulay@homeaway.com>
Addded a test
5c7b9fe 
Signed-off-by: Robert Macaulay <rmacaulay@homeaway.com>
@mikkokar mikkokar merged commit f8b8895 into ExpediaGroup:master Dec 13, 2019
@taer taer deleted the addToEventListener branch December 13, 2019 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikkokar mikkokar mikkokar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@taer @mikkokar