Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cut back excessive logging. #559

Merged
merged 8 commits into from
Dec 10, 2019
Merged

Cut back excessive logging. #559

merged 8 commits into from
Dec 10, 2019

Conversation

mikkokar
Copy link
Contributor

@mikkokar mikkokar commented Dec 9, 2019 •
edited
Loading

Styx build logs have increased over the time. They have started to exceed 4MB, tripping the Travis build. This PR is to cut back unnecessary log volume so that Travis can keep going.

Changes:

  • Add a Logback.xml file for each test suite. Turn most loggers off.
  • Where a test starts a styx server, provide a test Logback.xml with minimum logging enabled.
  • Convert some printf statements, in test files, to logger invocations.

With these changes, the log goes from 4MB down to about 970KB.

@mikkokar mikkokar marked this pull request as ready for review December 10, 2019 08:21
@mikkokar mikkokar merged commit d7d0fee into ExpediaGroup:master Dec 10, 2019
@mikkokar mikkokar deleted the reduce-logging branch December 10, 2019 08:45
@mikkokar mikkokar mentioned this pull request Dec 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OwenLindsell OwenLindsell OwenLindsell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikkokar @OwenLindsell