Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ProxyServerBuilder class. #581

Merged
merged 1 commit into from
Jan 7, 2020
Merged

Remove ProxyServerBuilder class. #581

merged 1 commit into from
Jan 7, 2020

Conversation

mikkokar
Copy link
Contributor

@mikkokar mikkokar commented Jan 7, 2020

Remove ProxyServerBuilder class. Configure the Netty server in a static method instead.

@mikkokar mikkokar mentioned this pull request Jan 7, 2020
Closed
@mikkokar mikkokar merged commit c04cc54 into ExpediaGroup:master Jan 7, 2020
@mikkokar mikkokar deleted the remove-proxy-server-builder branch January 7, 2020 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OwenLindsell OwenLindsell OwenLindsell approved these changes

@dvlato dvlato Awaiting requested review from dvlato

@chrisgresty chrisgresty Awaiting requested review from chrisgresty

@Noddy76 Noddy76 Awaiting requested review from Noddy76

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikkokar @OwenLindsell