Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inject Netty executors into Styx Core. #583

Merged
merged 2 commits into from
Jan 14, 2020
Merged

Inject Netty executors into Styx Core. #583

merged 2 commits into from
Jan 14, 2020

Conversation

mikkokar
Copy link
Contributor

@mikkokar mikkokar commented Jan 8, 2020 •
edited
Loading

Provide a new NettyExecutor class that encapsulates a Netty IO event loop with appropriate channel type identifiers. This class replaces existing classes/files:

  • ClientEventLoopFactory
  • PlatformAwareClientEventLoopGroupFactory
  • EpollClientEventLoopGroupFactory
  • NioClientEventLoopGroupFactory
  • PlatformAwareServerEventLoopFactory.java
  • ServerEventLoopFactories.java
  • EpollServerEventLoopGroupFactory.java
  • NioEventLoopGroups.java
  • NioServerEventLoopGroupFactory.java

The new NettyExecutor is then injected in the Styx Core.

Also removes NettyServerBuilderSpec class.

@mikkokar mikkokar marked this pull request as ready for review January 9, 2020 13:02
@mikkokar mikkokar mentioned this pull request Jan 10, 2020
Closed
@mikkokar mikkokar closed this Jan 13, 2020
@mikkokar mikkokar reopened this Jan 13, 2020
@mikkokar mikkokar merged commit c9298c0 into ExpediaGroup:master Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OwenLindsell OwenLindsell OwenLindsell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikkokar @OwenLindsell