Sanitize logged headers and cookies from Netty HTTP objects #590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Noddy76
reviewed
Jan 14, 2020
components/common/src/main/java/com/hotels/styx/common/format/SanitisedHttpHeaderFormatter.java
Outdated
Show resolved
Hide resolved
dvlato
reviewed
Jan 15, 2020
components/common/src/main/java/com/hotels/styx/common/format/SanitisingThrowableFactory.java
Outdated
Show resolved
Hide resolved
OwenLindsell
approved these changes
Jan 17, 2020
dvlato
reviewed
Jan 17, 2020
pom.xml
Outdated
| @@ -118,6 +118,7 @@ | |||
| <reactive-streams.version>1.0.2</reactive-streams.version> | |||
| <reactor.version>3.3.0.RELEASE</reactor.version> | |||
| <pcollections.version>3.0.3</pcollections.version> | |||
| <cglib.version>3.3.0</cglib.version> | |||
There was a problem hiding this comment.
Can you please remove this property?
pom.xml
Outdated
| <dependency> | ||
| <groupId>net.bytebuddy</groupId> | ||
| <artifactId>byte-buddy</artifactId> | ||
| <version>1.10.6</version> |
There was a problem hiding this comment.
Should we add the version as a property as done for cglib previously?
| @@ -15,17 +15,21 @@ | |||
| */ | |||
| package com.hotels.styx.logging | |||
|
|
|||
| import ch.qos.logback.classic.Level.INFO | |||
| import ch.qos.logback.classic.Level.* | |||
There was a problem hiding this comment.
We don't usually do star imports ... I assume it's your IDE doing that after N arguments. Can you check the configuration?
| * @param formatter hides the sensitive cookies. | ||
| * @return the proxied Throwable, or the supplied Target if it cannot be proxied. | ||
| */ | ||
| public Throwable create(Throwable target, SanitisedHttpHeaderFormatter formatter) { |
There was a problem hiding this comment.
Target seems fine in the context of creating a Proxy, but I wonder if it would a bit clearer if we indicated it's the origin exception. Just nitpicking :)
...nents/common/src/main/java/com/hotels/styx/common/format/SanitisingThrowableInterceptor.java
Outdated
Show resolved
Hide resolved
dvlato
approved these changes
Jan 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #573