New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace RxJava - Part 10 #592

Merged

OwenLindsell merged 1 commit into ExpediaGroup:master from OwenLindsell:remove-rxjava-from-tests

Jan 23, 2020

Contributor

OwenLindsell commented Jan 16, 2020

Remove RxJava from tests


          remove rxJava

5bb8512

dvlato reviewed

View reviewed changes

system-tests/e2e-suite/src/test/scala/com/hotels/styx/plugins/AggregatingPluginSpec.scala

                     mockServer.stub("/body", responseSupplier(
-                      () => response(OK).body(new ByteStream(toPublisher(Observable.from(Seq(chunk("a"), chunk("b"), chunk("c"), chunk("d"), chunk("e")).asJava)))).build()
+                      () => response(OK).body(new ByteStream(chunks)).build()

Contributor

dvlato Jan 16, 2020

We would usually inline the object.

dvlato approved these changes

View reviewed changes

OwenLindsell merged commit c1599d3 into ExpediaGroup:master

OwenLindsell mentioned this pull request

Styx Forwarding Path Improvements #577

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet