Release artifacts from Travis #594
Conversation
travis/deploy.sh
Outdated
| mvn install -f distribution/pom.xml -B -U -P docker -Dstyxcore.docker.image=dlatorre/styx | ||
| docker push dlatorre/styx |
There was a problem hiding this comment.
Should these lines include 'dlatorre'?
.github/workflows/verifybuild.yml
Outdated
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@v1 |
There was a problem hiding this comment.
Hi @dvlato. When searching the documentation, it is always checkout@v2 (https://github.com/actions/checkout) that comes out at the top.
Therefore asking, how did you come about using checkout@v1? Do you know if the v1 and v2 are related in any way? Should be using the v2 since it is newer? Etc.
There was a problem hiding this comment.
Okay I see, the examples for Setup-java are using checkout@v1. (https://github.com/actions/setup-java).
There was a problem hiding this comment.
There was a problem hiding this comment.
see the 'maven guide' was updated from checkout@v1 to @v2 around Christmas time: https://github.com/actions/starter-workflows/blob/master/ci/maven.yml
travis/deploy.sh
Outdated
| mvn deploy --settings travis/mvn-settings.xml -B -U -P sonatype-oss-release,linux -DskipTests=true -Dmaven.test.skip=true | ||
| #Deploy to dockerhub | ||
| echo "$DOCKER_PASSWORD" | docker login -u "$DOCKER_USERNAME" --password-stdin | ||
| mvn install -f distribution/pom.xml -B -U -P docker -Dstyxcore.docker.image=dlatorre/styx |
There was a problem hiding this comment.
This still has your user name in it:
-Dstyxcore.docker.image=dlatorre/styx
Also below:
docker push dlatorre/styx
Push them to: https://hub.docker.com/repository/docker/hotelsdotcom/styx
There was a problem hiding this comment.
I think before that I would need to have credentials to push to hotelsdotcom/styx :) I think I mentioned quite a few days ago that we could not merge as is but should discuss the approach...
No description provided.