Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

maximum header size not configurable for responses received from origins #598

Closed
dvlato opened this issue Jan 27, 2020 · 0 comments
Closed

maximum header size not configurable for responses received from origins #598

dvlato opened this issue Jan 27, 2020 · 0 comments

Comments

@dvlato
Copy link
Contributor

dvlato commented Jan 27, 2020 •
edited
Loading

The problem

The value for maximum size of headers returned by an origin is currently hardcoded to 8192 bytes.

Detailed description

Currently Styx rejects any response from an origin whenever the header size is larger than 8192 bytes without any option to configure the max header size for received responses.

There is a parameter maxHeaderSize that allows configuring the maximum header size for requests received by styx-server, but there is no equivalent configuration for the client side (outgoing connection to the origins) and the default value is always used.
@dvlato dvlato changed the title maxHeaderSize not configurable for the client side maxHeaderSize not configurable for responses received from origins Jan 28, 2020
dvlato pushed a commit to dvlato/styx that referenced this issue Jan 28, 2020
@a-dlatorre
Allow configuring the maximum header size of origin responses Expedia…
35c0ba9 
…Group#598
@dvlato dvlato mentioned this issue Jan 28, 2020
Merged
@dvlato dvlato changed the title maxHeaderSize not configurable for responses received from origins maximum header size not configurable for responses received from origins Jan 29, 2020
dvlato added a commit that referenced this issue Jan 29, 2020
@dvlato
Allow configuring the maximum header size of origin responses (issue #…
7558fce 
…598) (#599)

Add option to configure max origin bound header size (issue #598)
@dvlato dvlato closed this as completed Jan 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dvlato