Block server start until origins file is loaded. #643
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Description:
YamlFileConfigurationService
doesn't prevent Styx HTTP server from starting if it doesn't successfully load an initial origins configuration file.Therefore, Styx server starts without sensible origins configuration. All requests to its HTTP port will return
404 NOT FOUND
, with messageNot found: pathPrefixRouter
in response body.This affects only the new
YamlFileConfigurationService
. The old monolithic application router is unaffected.Root Cause & The Fix
Problem was caused by
ServiceProviderMonitor
which loads all service providers from Yamlproviders
block. It didn't wait for the underlying service providers to be started correctly.I fixed this by modifying the
ServiceProviderMonitor
class so that it waits for all underlying services to successfully start up before declaring itself as healthy tophase1
service manager.