Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

final rx java removal #652

Merged
merged 2 commits into from
Apr 15, 2020
Merged

final rx java removal #652

merged 2 commits into from
Apr 15, 2020

Conversation

OwenLindsell
Copy link
Contributor

No description provided.

mikkokar
mikkokar suggested changes Apr 8, 2020
View reviewed changes
Copy link
Contributor

@mikkokar mikkokar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @OwenLindsell . Thanks for this! Can you check the logging output from CI run please? The CI run started erring (not failing) due to excessive logging.

@OwenLindsell
Copy link
Contributor Author

Hi @OwenLindsell . Thanks for this! Can you check the logging output from CI run please? The CI run started erring (not failing) due to excessive logging.

Which errors specifically? There are a lot of errors in the log 😄
You think the increase in logging is caused by this PR?

@mikkokar
Copy link
Contributor

mikkokar commented Apr 9, 2020

Hi @OwenLindsell . Thanks for this! Can you check the logging output from CI run please? The CI run started erring (not failing) due to excessive logging.

Which errors specifically? There are a lot of errors in the log 😄
You think the increase in logging is caused by this PR?

Master build 2122:

B/s)
[INFO] Downloading from maven-central-mirror: https://maven-central.storage-download.googleapis.com/maven2/org/apache/maven/doxia/doxia-module-xhtml/1.4/doxia-module-xhtml-1.4.pom
[INFO] Downloaded from maven-central-mirror: https://maven-central.storage-download.googleapis.com/maven2/org/apache/maven/doxia/doxia-module-xhtml/1.4/doxia-module-xhtml-1.4.pom (0 B at 0 B/s)
[INFO] Downloading from maven-central-mirror: https://maven-central.storage-download.googleapis.com/maven2/org/apache/maven/doxia/doxia-modules/1.4/doxia-modules-1.4.pom
[INFO] Downloaded from maven-central-mirror: https://maven-central.storage-download.googleapis.com/maven2/org/apache/maven/doxia/doxia-modules/1.4/doxia-modules-1.4.pom (0 B at 0 B/s)
[INFO] Downloading from maven-central-mirror: https://maven-central.storage-download.googleapis.com/maven2/org/apache/maven/doxia/doxia-module-fml/1

The job exceeded the maximum log length, and has been terminated.

@OwenLindsell
Copy link
Contributor Author

OwenLindsell commented Apr 14, 2020 •
edited
Loading

Ah ok, this is not actually related to this PR, but I see it's a blocker for merging any PR. We have a story for this in Trello:
https://trello.com/c/mnChSQv1/150-excessive-logging-in-ci-environment

Can I get an approval for this PR and we will only merge once the above story is complete?

mikkokar
mikkokar approved these changes Apr 14, 2020
View reviewed changes
components/server/src/main/java/com/hotels/styx/server/netty/connectors/HttpResponseWriter.java Outdated
protected void hookOnNext(Buffer b) {
Buffers.toByteBuf(b).release();
}
});
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should use the ByteStream.drop instead:

            Flux.from(response.body()
                    .drop())
                    .subscribe();

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, much neater! done :)

@OwenLindsell OwenLindsell merged commit 3da7848 into ExpediaGroup:master Apr 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikkokar mikkokar mikkokar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OwenLindsell @mikkokar