Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix deprecated dependencies #1360

Open
2 tasks done
rgon opened this issue Sep 14, 2024 · 4 comments
Open
2 tasks done

fix deprecated dependencies #1360

rgon opened this issue Sep 14, 2024 · 4 comments

Comments

@rgon
Copy link

rgon commented Sep 14, 2024

Describe the feature

Houdini is importing a deprecated, old (2022) version of glob, polluting a depending project's audit & pnpm install with warnings.

"glob": "^8.0.3",

"glob": "^8.0.3",

This probably shouldn't matter much, but that version of glob in turn imports inflight@1.0.6 which is deprecated at its last version, leaks memory and seems to be a bit bigger of an issue.

Criticality

nice to have

Tasks

@rgon rgon changed the title (chore): update deprecated "glob" dependency fix deprecated dependencies Sep 14, 2024
@rgon
Copy link
Author

rgon commented Sep 15, 2024

Deprecated devDependencies

There are also the following deprecated dependencies in the main houdini monorepo:

$ pnpm i
Scope: all 16 workspace projects
site                                     |  WARN  deprecated mermaid.cli@0.3.6

And it's imported by remark-mermaid@0.2.0 in the /site project. This is a project with no updates in 7 years: https://www.npmjs.com/package/remark-mermaid that depends on mermaid.cli, which is in turn dead.

It can be directly replaced with https://www.npmjs.com/package/@theguild/remark-mermaid . The documentation shows only an install is needed, and no code modification.

@fnimick
Copy link
Contributor

fnimick commented Sep 27, 2024

houdini-svelte also installs an old version of svelte svelte@"^3.57.0" even in the latest version, btw.

@Rudedog9d
Copy link

houdini-svelte also installs an old version of svelte svelte@"^3.57.0" even in the latest version, btw.

Yea, svelte is 3.57, and sveltekit is @sveltejs/kit@^1.9.3

@SeppahBaws
Copy link
Collaborator

Hey all,

We're aware that houdini-svelte has outdated svelte and svelte-kit dependencies. During an attempt to bring them up to date with svelte 4 and svelte-kit 2, they were giving peerdependency warnings that I wasn't able to work around.

When svelte 5 is released and #1300 is merged, the svelte and svelte-kit versions will be up to date again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants