Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speed issues formatting complex JSON #234

Closed
ygraber opened this issue Aug 15, 2018 · 1 comment
Closed

Speed issues formatting complex JSON #234

ygraber opened this issue Aug 15, 2018 · 1 comment

Comments

@ygraber
Copy link
Contributor

ygraber commented Aug 15, 2018

  • VSCode Version: 1.26.0
  • OS Version: Windows 10
  • REST Client Version: 0.19.1

Steps to Reproduce:

  1. GET http://www.vizgr.org/historical-events/search.php?format=json&begin_date=-3000000&end_date=20151231&lang=en
  2. Wait, Wait, Wait

The speed of formatting JSON using the current parser seems to be related to number of "edits" not size of JSON. I have switched to 'js-beautify' and have made a PR: #233 I'm hoping it will be accepted. (after I fix my linting issues)
@Huachao Huachao closed this as completed Aug 17, 2018
@Huachao
Copy link
Owner

Huachao commented Aug 17, 2018

Already merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Huachao @ygraber