-
Notifications
You must be signed in to change notification settings - Fork 445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Does it support client certificate authentication? #35
Comments
@zephrxx it's not supported now, thanks for your suggestion and I will put it in my backlog |
This one should be fairly easy to implement. I can imagine 3 more items in the request:
All three can be in the plain text form, eligible for env. params substitution (environment aware). https://www.npmjs.com/package/request#tlsssl-protocol for more. |
@defectus you are right, I am considering that how to let user to specify these items in request, the more direct way seems to put in request(that seems needs to create a new syntax to set these value), others ways are putting in setting files, or even add some dialogs to let user to CRUD these friendly |
Just keep in mind that for many people (at least for me :-)) client certificates differ between environments. We use different client certificates in production, staging and integration. Whatever way you plan to implement this feature please allow us to easily configure certificates based on the selected environment. |
An idea good be to use the underlaying OS certificate store which should work fine for Windows and MacOS. Referencing the Certificate could be done be specifing the store and fingerprint. |
@zephrxx @defectus @kwaxi @VitorLuizC @mFingers @ytimenkov I have implemented the client certificate feature, and will publish it in next version |
@zephrxx @defectus @kwaxi @VitorLuizC @mFingers @ytimenkov You can use the latest version 0.14.0, you can also follow the |
Just tested it, works nicely! Good job, many thanks! |
There are two different interpretations of "client certificate authentication":
Is there a way to generate the client_assertion which is needed for the cert. based OAuth-Login to a Azure AD? |
Some rest api requires client cert authentication.
The text was updated successfully, but these errors were encountered: