Cannot read property 'toCustomLabel' of undefined

[normalser]

• VSCode Version: Code - Insiders 1.6.0-insider (be5e8d5, 2016-09-26T06:05:01.421Z)
• OS Version: Darwin x64 16.0.0
• REST Client Version: 0.8.3

Extension causes this issue:
microsoft/vscode#12709

[Huachao]

@wallverb are you using windows or macOS, since from the command you use, it seems macOS. Anyway, can you click the tab on VS Code: Help -> Toggle Developer Tools, and then you press the failed command, it will show error details in the Console in the developer tools view.

[normalser]

@Huachao - macOS, here is the info:

Conflict detected, command `toggleSearchRegex` cannot be triggered by alt+cmd+r due to rest-client.request
workbench.main.js:62 Conflict detected, command `toggleFindRegex` cannot be triggered by alt+cmd+r due to rest-client.request
workbench.main.js:93 Cannot read property 'toCustomLabel' of undefined: TypeError: Cannot read property 'toCustomLabel' of undefined
    at t.getLabelFor (file:////Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:92:28490)
    at Object.w [as appendKeyBindingLabel] (file:////Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:114:31225)
    at t.renderSearchInput (file:////Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:115:17546)
    at t.render (file:////Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:115:16649)
    at new t (file:////Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:115:15296)
    at t.createSearchWidget (file:////Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:115:31681)
    at t.create (file:////Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:115:28453)
    at e.<anonymous> (file:////Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:116:26052)
    at e.doElement (file:////Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:35:14008)
    at e.div (file:////Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:35:13050)

[Huachao]

@wallverb it seems the keyboard shortcut I defined for request conflicts with the command toggleSearchRegex. Does this command also use the alt+cmd+r shortcut?

[normalser]

I see this in Preferences -> keybindings.json of code-insinders

{ "key": "alt+cmd+r",             "command": "toggleSearchRegex",
                                     "when": "searchInputBoxFocus && searchViewletVisible" },

but the issue happen even without pressing any shortcut

Here is the start:

and I will click Search icon in the left bar:

[Huachao]

@wallverb can you help to try to add below code in Preferences -> keybindings.json, and check it will work?

{ "key": "cmd+alt+r",            "command": "rest-client.request",
                                     "when": "editorTextFocus && editorLangId == 'http'" },
{ "key": "cmd+alt+r",            "command": "rest-client.request",
                                     "when": "editorTextFocus && editorLangId == 'plaintext'" }

[normalser]

FYI:

this helps: (to cancel first that global command)

{ "key": "alt+cmd+r",            "command": "-rest-client.request"},
  { "key": "cmd+alt+r",            "command": "rest-client.request",
                                     "when": "editorTextFocus" }

[Huachao]

@wallverb I will publish a release right now and after that you can remove the hack, and sorry for the inconvenience.

[normalser]

Awesome, no worries, thanks a lot

[Huachao]

@wallverb you can try the latest version 0.8.4 now, thanks 😄

[normalser]

Sure, I just did - works great 👍