Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shallowEqual compare does not correctly update its value #111

Open
NickKirschke opened this issue Nov 3, 2022 · 0 comments
Open

shallowEqual compare does not correctly update its value #111

NickKirschke opened this issue Nov 3, 2022 · 0 comments

Comments

@NickKirschke
Copy link

NickKirschke commented Nov 3, 2022

@aem

When returning multiple values from a dependency within an object, the shallowEqual incorrectly evaluates whether or not there was a change in value depending on the order and type of these values. If both values are updated, the dependency will recalculate.

// Updating only the bar ImmutableMap below will not trigger a value update for this dependency
{
  foo: [123],
  bar: ImmutableMap({
    baz: "baz"
  }),
}

// Updating only the bar ImmutableMap below will trigger a value update for this dependency
{
  bar: ImmutableMap({
    baz: "baz"
  }),
  foo: [123],
}
@NickKirschke NickKirschke changed the title shallowEqual compare for arrays does not properly evaluate new values shallowEqual compare does not correctly update its value Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant