Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Research Group Template to Block v2 #2908

Closed
2 tasks done
Agos95 opened this issue Jan 26, 2023 · 3 comments · Fixed by #2914
Closed
2 tasks done

Update Research Group Template to Block v2 #2908

Agos95 opened this issue Jan 26, 2023 · 3 comments · Fixed by #2914

Comments

@Agos95
Copy link
Contributor

Agos95 commented Jan 26, 2023

Prerequisites

  • I have searched for duplicate or closed feature requests
  • I am mindful of the project scope

Proposal

I am updating the Research Group template to v2 block system.
In this template there is the slider widget, which is not yet ported to the v2 version.
I alredy modify it to work with the block system (essentially it was a simple replace of $block.Params.* with $block.*).
However, I was wandering if something more should be done in order to align it with the other blocks.

Otherwise, I will do a pull request as soon as I finish to check the template.

Motivation and context

The Academic and Minimal template have alredy beeen ported to the v2 block system, so I think that the other ones should be ported too, since the future version of Wowchemy will switch from the widget page to the landing one. In addition, a user in Discord asked for the v2 version of the Research Group template.

@Agos95
Copy link
Contributor Author

Agos95 commented Jan 27, 2023

The other possibility is to uniform the background parameter of each slide as desribed in the homepage documentation.
In this way, we have a common interface for the background (both for a block background and the slide backgrouns); the downside is that users need to change they own code when updating to the new version.

@gcushen
Copy link
Collaborator

gcushen commented Feb 1, 2023

The other possibility is to uniform the background parameter of each slide as desribed in the homepage documentation. In this way, we have a common interface for the background (both for a block background and the slide backgrouns); the downside is that users need to change they own code when updating to the new version.

Yes, if we port the Slider block to the v2 collection, then let's attempt to align the parameters and data structure with those used elsewhere in the latest version. There will be some options which won't be appropriate in this scenario, for example, we plan to only support background images and background colors/gradients in slides and not support videos or effects like parallax.

Having consistent parameters and structure should make the experience simpler and more intuitive for new users.

@github-actions
Copy link

github-actions bot commented Mar 4, 2023

This issue is stale because it has not had any recent activity. The resources of the project maintainers are limited, and so we are asking for your help.

If this is a bug and you can still reproduce this error on the main branch, consider contributing a Pull Request with a fix.

If this is a feature request, and you feel that it is still relevant and valuable, consider contributing a Pull Request for review.

This issue will automatically close soon if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Mar 4, 2023
@github-actions github-actions bot closed this as completed Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants