Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

url_custom button size varies with size of icon #872

Closed
jessebett opened this issue Jan 10, 2019 · 1 comment
Closed

url_custom button size varies with size of icon #872

jessebett opened this issue Jan 10, 2019 · 1 comment
Labels
Milestone

Comments

@jessebett
Copy link

When using url_custom, for example below a project card, the size of the box changes with the size of the icon. This is especially annoying because it disallows mixing icon'd and non-icon'd urls. Further, it isn't even consistent between styles of fontawesome icons.

For example, using an icon from fab and far isn't consistently sized:

url_custom = [
{name="no icon", url = "https://twitter.com/georgecushen"},
{icon_pack = "fab", icon="twitter", name="Follow", url = "https://twitter.com/georgecushen"},
{icon_pack = "far", icon="file-powerpoint", name="Slides", url = "https://twitter.com/georgecushen"}
]

produces:

image

You can see that the only change is the presence of an icon and what pack it's from, but this causes the button size to change. It's very subtle but I believe the difference between no icon and fab icon to be slightly different too.

It would be nice if the button size was independent so icons from different styles could be used interchangeably.

@gcushen gcushen added the bug label Jan 12, 2019
@gcushen gcushen added this to the v3.4 milestone Jan 12, 2019
@gcushen
Copy link
Collaborator

gcushen commented Jan 12, 2019

Thanks for reporting this issue which has now been fixed. Please update to the latest master version of Academic to get the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants