Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deployment should not rely on existence of test buckets #923

Closed
xbrianh opened this issue Jan 25, 2018 · 0 comments · Fixed by #924
Closed

Deployment should not rely on existence of test buckets #923

xbrianh opened this issue Jan 25, 2018 · 0 comments · Fixed by #924
Assignees
@xbrianh
Labels
BUG
Milestone
DSS Sprint 16

Comments

@xbrianh
Copy link
Member

xbrianh commented Jan 25, 2018

The deployment package of dss-gs-event-relay is staged into the GCP test fixtures bucket:

data-store/scripts/deploy_gcf.py

Line 72 in 30c7cf1

deploy_blob = gs.bucket(os.environ["DSS_GS_BUCKET_TEST_FIXTURES"]).blob(deploy_filename)

If the user does not wish to run tests, and thus has not created the test buckets, their deployment will fail.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xbrianh xbrianh

Labels
BUG
Projects
None yet
Milestone
DSS Sprint 16
Development

Successfully merging a pull request may close this issue.

Use gcloud command to deploy dss-gs-event-relay HumanCellAtlas/data-store
3 participants
@Bento007 @kozbo @xbrianh