Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize attachBarcodes in sctools #860

Open
kbergin opened this issue Mar 10, 2020 · 0 comments
Open

Optimize attachBarcodes in sctools #860

kbergin opened this issue Mar 10, 2020 · 0 comments

Comments

@kbergin
Copy link

kbergin commented Mar 10, 2020

Why?

AttachBarcodes is one of the longest steps in the Optimus pipeline. 3.5 hours on PBMC4k. 6 hours on Bo Li’s test dataset for the cumulus package. We need to make the step faster.

The code can probably be improved, but it is also theoretically parallelizable.

Where to start?

The related code's entry is probably here, from [~accountid:557058:32a3563d-4613-4e1b-a777-0770d66a2e0c]. Ambrose Carr may have ideas on how to improve this step. There is the possibility of error rate related bottleneck that should be investigated.

AC:

  • AttachBarcodes is faster and does not change the outputs scientifically
  • Update tests in sctools, add if needed
  • Release sctools

It’s possible the below can go to a new ticket

  • Update Optimus version of sctools
  • Coordinate with Jodi to update documentation
  • Update pipeline tests if needed

┆Issue is synchronized with this Jira Dev Task

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant